-
Notifications
You must be signed in to change notification settings - Fork 71
[AIFA] Add new object type #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
13d0b75
Add file format for AIFA
Smartynkov 32e6166
aifa types naming fix
Smartynkov 911d4ec
error handling fix
Smartynkov ef11b50
lint fix
Smartynkov f8e0ef1
small adjustments
Smartynkov 54705fe
lint fix
Smartynkov cde4c90
Merge branch 'SAP:main' into feature/aifa
Smartynkov 855885c
Number (Numeric_id) adjustments
Smartynkov a33f7cd
lint_fix
Smartynkov 750fea3
Check naming changes
Smartynkov d76052e
fix
Smartynkov 912386d
post review changes
Smartynkov 85133bb
example object for AIFA
Smartynkov 4a18040
format version add
Smartynkov b3284a3
description
Smartynkov 95a2b59
LF
Smartynkov f6cb846
fix
Smartynkov 088b919
Dropdown name adjustments
Smartynkov d03b35b
Merge branch 'main' into feature/aifa
schneidermic0 e342a61
Merge branch 'main' into feature/aifa
wurzka a3bcc34
After UX review update
Smartynkov ed71428
UX review fixes
Smartynkov bbd9e57
Json Format version fix
Smartynkov 3d45b8f
Fix example
wurzka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # AIFA File Format | ||
|
|
||
| File | Cardinality | Definition | Schema | Example | ||
| :--- | :--- | :--- | :--- | :--- | ||
| `<name>.aifa.json` | 1 | [`zif_aff_aifa_v1.intf.abap`](./type/zif_aff_aifa_v1.intf.abap) | [`aifa-v1.json`](./aifa-v1.json) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,184 @@ | ||
| { | ||
| "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/aifa/aifa-v1.json", | ||
| "title": "Action", | ||
| "description": "Action", | ||
| "type": "object", | ||
| "properties": { | ||
| "formatVersion": { | ||
| "title": "ABAP File Format Version", | ||
| "description": "The ABAP file format version", | ||
| "type": "string", | ||
| "const": "1" | ||
| }, | ||
| "header": { | ||
| "title": "Header", | ||
| "description": "Header", | ||
| "type": "object", | ||
| "properties": { | ||
| "description": { | ||
| "title": "Description", | ||
| "description": "Description of the ABAP object", | ||
| "type": "string", | ||
| "maxLength": 60 | ||
| }, | ||
| "originalLanguage": { | ||
| "title": "Original Language", | ||
| "description": "Original language of the ABAP object", | ||
| "type": "string", | ||
| "minLength": 2 | ||
| }, | ||
| "abapLanguageVersion": { | ||
| "title": "ABAP Language Version", | ||
| "description": "ABAP language version", | ||
| "type": "string", | ||
| "enum": [ | ||
| "standard", | ||
| "cloudDevelopment" | ||
| ], | ||
| "enumTitles": [ | ||
| "Standard", | ||
| "ABAP Cloud Development" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "Standard", | ||
| "ABAP cloud development" | ||
| ], | ||
| "default": "standard" | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "description", | ||
| "originalLanguage" | ||
| ] | ||
| }, | ||
| "generalInformation": { | ||
| "title": "General Information", | ||
| "description": "General information", | ||
| "type": "object", | ||
| "properties": { | ||
| "namespace": { | ||
| "title": "Namespace", | ||
| "description": "Namespace", | ||
| "type": "string", | ||
| "maxLength": 15 | ||
| }, | ||
| "aifAction": { | ||
| "title": "AIF Action", | ||
| "description": "AIF action", | ||
| "type": "string", | ||
| "maxLength": 20 | ||
| }, | ||
| "mainComponentType": { | ||
| "title": "Main Component Type", | ||
| "description": "Main component type", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "class": { | ||
| "title": "Class", | ||
| "description": "Class", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "namespace", | ||
| "aifAction" | ||
| ] | ||
| }, | ||
| "fieldRestore": { | ||
| "title": "Fields To Restore", | ||
| "description": "Fields to restore", | ||
| "type": "array", | ||
| "items": { | ||
| "title": "Field To Restore", | ||
| "description": "Field to restore", | ||
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "title": "Name", | ||
| "description": "Name", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| } | ||
| }, | ||
| "checkData": { | ||
| "title": "Checks", | ||
| "description": "Checks", | ||
| "type": "array", | ||
| "items": { | ||
| "title": "Check Details", | ||
| "description": "Check details", | ||
| "type": "object", | ||
| "properties": { | ||
| "number": { | ||
| "title": "Number", | ||
| "description": "Number", | ||
| "type": "string", | ||
| "maxLength": 3, | ||
| "pattern": "^[0-9]+$" | ||
| }, | ||
| "checkObjName": { | ||
| "title": "Check", | ||
| "description": "Check", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "checkBehaviour": { | ||
| "title": "Check Behavior", | ||
| "description": "Check behavior", | ||
| "type": "string", | ||
| "enum": [ | ||
| "triggerError", | ||
| "ignoreData" | ||
| ], | ||
| "enumTitles": [ | ||
| "Treat As Error", | ||
| "Ignore Data" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "Treat as error if check is not successful", | ||
| "Ignore data if check is not successful" | ||
| ], | ||
| "default": "ignoreData" | ||
| }, | ||
| "fieldName": { | ||
| "title": "Field Name", | ||
| "description": "Field name", | ||
| "type": "array", | ||
| "items": { | ||
| "title": "Field To Check", | ||
| "description": "Field to check", | ||
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "title": "Field Name", | ||
| "description": "Field name", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| } | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "number", | ||
| "checkObjName" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "formatVersion", | ||
| "header", | ||
| "generalInformation" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| INTERFACE zif_aff_aifa_v1 | ||
| PUBLIC. | ||
|
|
||
| "! $values { @link zif_aff_aifa_v1.data:co_error_handling } | ||
| "! $default { @link zif_aff_aifa_v1.data:co_error_handling.ignore_data } | ||
| TYPES ty_error_handling_type TYPE c LENGTH 1. | ||
| CONSTANTS: | ||
| BEGIN OF co_error_handling, | ||
| "! <p class="shorttext">Treat As Error</p> | ||
| "! Treat as error if check is not successful | ||
| trigger_error TYPE c LENGTH 1 VALUE '', | ||
wurzka marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Smartynkov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Ignore Data</p> | ||
| "! Ignore data if check is not successful | ||
| ignore_data TYPE c LENGTH 1 VALUE 'I', | ||
| END OF co_error_handling. | ||
|
|
||
| TYPES: | ||
| "! <p class="shorttext">Field To Check</p> | ||
| "! Field to check | ||
| BEGIN OF ty_field_to_check, | ||
| "! <p class="shorttext">Field Name</p> | ||
Smartynkov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "! Field name | ||
| name TYPE string, | ||
| END OF ty_field_to_check, | ||
| "! <p class="shorttext">Fields To Check</p> | ||
| "! Fields to check | ||
| ty_fields_to_check TYPE STANDARD TABLE OF ty_field_to_check WITH DEFAULT KEY. | ||
|
|
||
| TYPES: | ||
| "! <p class="shorttext">General Information</p> | ||
| "! General information | ||
| BEGIN OF ty_general_information, | ||
| "! <p class="shorttext">Namespace</p> | ||
| "! Namespace | ||
| "! $required | ||
| namespace TYPE c LENGTH 15, | ||
| "! <p class="shorttext">AIF Action</p> | ||
| "! AIF action | ||
| "! $required | ||
| aif_action TYPE c LENGTH 20, | ||
Smartynkov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Main Component Type</p> | ||
| "! Main component type | ||
| main_component_type TYPE zif_aff_types_v1=>ty_object_name_30, | ||
| "! <p class="shorttext">Class</p> | ||
| "! Class | ||
| class TYPE zif_aff_types_v1=>ty_object_name_30, | ||
wurzka marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| END OF ty_general_information, | ||
|
|
||
| "! <p class="shorttext">Check Details</p> | ||
| "! Check details | ||
| BEGIN OF ty_check_details, | ||
| "! <p class="shorttext">Number</p> | ||
| "! Number | ||
| "! $required | ||
| number TYPE n LENGTH 3, | ||
Smartynkov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Check</p> | ||
| "! Check | ||
| "! $required | ||
| check_obj_name TYPE zif_aff_types_v1=>ty_object_name_30, | ||
Smartynkov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Check Behavior</p> | ||
| "! Check behavior | ||
| check_behaviour TYPE ty_error_handling_type, | ||
| "! <p class="shorttext">Field Name</p> | ||
| "! Field name | ||
Smartynkov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| field_name TYPE ty_fields_to_check, | ||
| END OF ty_check_details, | ||
| "! <p class="shorttext">Check Data</p> | ||
| "! Check data | ||
Smartynkov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ty_checks TYPE STANDARD TABLE OF ty_check_details WITH DEFAULT KEY, | ||
|
|
||
| "! <p class="shorttext">Field To Restore</p> | ||
| "! Field to restore | ||
| BEGIN OF ty_field_to_restore, | ||
| "! <p class="shorttext">Name</p> | ||
| "! Name | ||
| name TYPE string, | ||
| END OF ty_field_to_restore, | ||
| "! <p class="shorttext">Fields To Restore</p> | ||
| "! Fields to restore | ||
| ty_fields_to_restore TYPE STANDARD TABLE OF ty_field_to_restore WITH DEFAULT KEY, | ||
|
|
||
| "! <p class="shorttext">Action</p> | ||
| "! Action | ||
| BEGIN OF ty_main, | ||
| "! $required | ||
| format_version TYPE zif_aff_types_v1=>ty_format_version, | ||
| "! <p class="shorttext">Header</p> | ||
| "! Header | ||
| "! $required | ||
| header TYPE zif_aff_types_v1=>ty_header_60_cloud, | ||
| "! <p class="shorttext">General Information</p> | ||
| "! General information | ||
| "! $required | ||
| general_information TYPE ty_general_information, | ||
| "! <p class="shorttext">Fields To Restore</p> | ||
| "! Fields to restore | ||
| field_restore TYPE ty_fields_to_restore, | ||
Smartynkov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Smartynkov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "! <p class="shorttext">Checks</p> | ||
| "! Checks | ||
| check_data TYPE ty_checks, | ||
Smartynkov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| END OF ty_main. | ||
|
|
||
| ENDINTERFACE. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "AFF Type for AIFA (Action)", | ||
| "originalLanguage": "en" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.