[SXTG] Add new object type SXTG

[robinPfaffSap]

No description provided.

[cla-assistant]

All committers have signed the CLA.

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Markus1812]

Hi Robin, thanks for your contribution. Your AFF already looks pretty good, I mainly have some comments regarding texts/naming.

One further question regarding the object type itself: SAP GUI Extension Points sound not like something that will be available in the cloud. Can you shortly explain your object type?

And one last question, is this an already existing object type or new development?

[robinPfaffSap]

Hi Marcus,

The object type “SAP GUI Extension Point” supports possibility to add Extension Fields created via Developer Extensibility (ALV 5 “ABAP for Cloud Development”) in ADT to SAP GUI screens. So it is available in Cloud.
The application includes a generic subscreen in their application UI, creates an abstract entity and applies the C0 contract for developer extensibility. This UI extension entity decides what fields are rendered on the dynpro UI.
Customers create extends for the abstract entity based on their extension fields from persistence Extension Include. All major properties are derived from the field definition (Texts, field type, value help support).

A customer has to know the following objects stored in the “SAP GUI Extension Point” to extend a SAP UI transaction:

• Extension Include (included in DB table and contains appended Developer Extension Fields)
• Application Data Structure (read-only application data for customer which at least contain key fields e.g. to validate or calculate Developer Extension Fields)
• UI Extension Entity (abstract entity which contains fields to be rendered on dynpro UI)

Also, to answer your question, this is a new development.

Best regards
Robin

[Markus1812]

Hi Robin, thanks for the explanation.

Sorry for the maybe confusing suggestions about upper/lower case styling in our title/descriptions. We require title case for titles and sentence case for descriptions:

"! <p class="shorttext">Title Case</p>
"! Sentence case

I've marked four instances below.

[Markus1812]

Hi Robin,

thanks for the update. Looks pretty good so far. I found one minor typo, could you please correct this?

Could you also provide an example JSON on how a serialized object will look like? Depending on how far your development is, you can either do this with our SAFF_GENERATE_REPO program by defining an already existing object as "Example Object Name" or you can use a tool like JSON Schema Faker and input the schema to generate a valid JSON. You can then modify the JSON to represent one example object with some realistic values.

Please upload your example json with the name z_aff_example_sxtg.sxtg.json into the folder file-formats/sxtg/examples/ and link it in the README.md by adding the following snippet to the end of the table.
| [z_aff_example_sxtg.sxtg.json](./examples/z_aff_example_sxtg.sxtg.json)

Thanks

[Markus1812]

Hi Robin, thanks for the example. One minor point that came up during a double-check. "SAP GUI" is a name and should therefore be written as it is named.

[schneidermic0]

@robinPfaffSap Thanks for your contribution.

Except the last change request of @Markus1812, this PR looks good to me. I found a minor remark, but as mentioned, maybe this should be also checked in the UX cross check.

[wurzka]

Hi @robinPfaffSap,
Could you please check the open conversations?
At least Michael's comment regarding "transactionCodes"."name" was also part of our UX review and I understood that you are ok with changing it

[robinPfaffSap]

Sorry for the late reaction. I must have just forgot to answer the mail.

[wurzka]

Thanks for the updates. When changing the example, the description somehow got lost. I took the description from the example before. If you're not fine with it please add an other.
Else looks good to me :)

[wurzka]

I guess we can merge this pull request. Thanks for contributing SXTG to our repository :)