[EDOT] Add new object EDOT #682
There are no files selected for viewing
wurzka marked this conversation as resolved.
Show resolved
Hide resolved
i506210 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # EDOT File Format | ||
|
|
||
| File | Cardinality | Definition | Schema | Example | ||
| :--- | :--- | :--- | :--- | :--- | ||
| `<name>.edot.json` | 1 | [`zif_aff_edot_v1.intf.abap`](./type/zif_aff_edot_v1.intf.abap) | [`edot-v1.json`](./edot-v1.json) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,165 @@ | ||
| { | ||
| "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edot/edot-v1.json", | ||
| "title": "eDocument Type", | ||
| "description": "eDocument type", | ||
| "type": "object", | ||
| "properties": { | ||
| "formatVersion": { | ||
| "title": "Format Version", | ||
| "description": "Format version", | ||
| "type": "string", | ||
| "const": "1" | ||
| }, | ||
| "header": { | ||
| "title": "Header", | ||
| "description": "Header", | ||
| "type": "object", | ||
| "properties": { | ||
| "description": { | ||
| "title": "Description", | ||
| "description": "eDocument type description", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "originalLanguage": { | ||
| "title": "Original Language", | ||
| "description": "Original language of the eDocument type", | ||
| "type": "string", | ||
| "minLength": 2 | ||
| }, | ||
| "abapLanguageVersion": { | ||
| "title": "ABAP Language Version", | ||
| "description": "ABAP language version", | ||
| "type": "string", | ||
| "enum": [ | ||
| "standard", | ||
| "cloudDevelopment" | ||
| ], | ||
| "enumTitles": [ | ||
| "Standard", | ||
| "ABAP Cloud Development" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "Standard", | ||
| "ABAP cloud development" | ||
| ], | ||
| "default": "standard" | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "description", | ||
| "originalLanguage" | ||
| ] | ||
| }, | ||
| "generalInformation": { | ||
| "title": "General Information", | ||
| "description": "General information", | ||
| "type": "object", | ||
| "properties": { | ||
| "tableName": { | ||
| "title": "eDocument Table Name", | ||
| "description": "eDocument table name", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "isArchivePreprocessNeeded": { | ||
| "title": "Preprocess Before Archiving", | ||
| "description": "Preprocess before archiving", | ||
| "type": "boolean" | ||
| }, | ||
| "isCreatedInContingencyMode": { | ||
| "title": "Created in Contingency Mode", | ||
| "description": "Created in contingency mode", | ||
| "type": "boolean" | ||
| }, | ||
| "contingencyEdocType": { | ||
| "title": "Contingency eDocument Type", | ||
| "description": "Contingency eDocument type", | ||
| "type": "string", | ||
| "maxLength": 10 | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| }, | ||
| "sralConfiguration": { | ||
| "title": "Additional Selection Fields", | ||
| "description": "Additional selection fields of validation report", | ||
| "type": "array", | ||
| "uniqueItems": true, | ||
| "items": { | ||
| "title": "SRAL Configuration Type", | ||
| "description": "SRAL configuration type", | ||
| "type": "object", | ||
| "properties": { | ||
| "fileType": { | ||
| "title": "File Type", | ||
| "description": "File type", | ||
| "type": "string", | ||
| "maxLength": 10 | ||
| }, | ||
| "fileStructure": { | ||
| "title": "File Structure Type", | ||
| "description": "File structure type", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| }, | ||
| "fileDescription": { | ||
| "title": "File Description", | ||
| "description": "File description", | ||
| "type": "string", | ||
| "maxLength": 60 | ||
| }, | ||
| "isCloudRelevant": { | ||
| "title": "File Cloud Relevancy", | ||
| "description": "File cloud relevancy", | ||
| "type": "boolean" | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "fileType", | ||
| "fileStructure" | ||
| ] | ||
| } | ||
| }, | ||
| "edocSpecAdditionalTable": { | ||
| "title": "eDocument Type Specific Additional Tables", | ||
| "description": "eDocument type specific additional tables", | ||
| "type": "array", | ||
| "uniqueItems": true, | ||
| "items": { | ||
| "title": "eDocument Type Specific Additional Tables", | ||
| "description": "eDocument type specific additional tables", | ||
| "type": "object", | ||
| "properties": { | ||
| "sequenceNumber": { | ||
| "title": "Sequence Number", | ||
| "description": "Sequence number", | ||
| "type": "string", | ||
| "maxLength": 10 | ||
| }, | ||
| "tableName": { | ||
| "title": "Table Name", | ||
| "description": "Table name", | ||
| "type": "string", | ||
| "maxLength": 30 | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "sequenceNumber", | ||
| "tableName" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "formatVersion", | ||
| "header", | ||
| "generalInformation" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,103 @@ | ||||||
| "! <p class="shorttext synchronized">AFF for eDocument Type (EDOT)</p> | ||||||
| "! eDocument types that can be used in eInvoice process | ||||||
| INTERFACE zif_aff_edot_v1 | ||||||
| PUBLIC. | ||||||
|
|
||||||
| TYPES: | ||||||
| "! <p class="shorttext">SRAL Configuration Type</p> | ||||||
| "! SRAL configuration type | ||||||
|
||||||
| BEGIN OF ty_sral_configuration, | ||||||
| "! <p class="shorttext">File Type</p> | ||||||
| "! File type | ||||||
| "! $required | ||||||
| file_type TYPE c LENGTH 10, | ||||||
i506210 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
| "! <p class="shorttext">File Structure Type</p> | ||||||
| "! File structure type | ||||||
| "! $required | ||||||
| file_structure TYPE c LENGTH 30, | ||||||
| "! <p class="shorttext">File Description</p> | ||||||
| "! File description | ||||||
| file_description TYPE c LENGTH 60, | ||||||
| "! <p class="shorttext">File Cloud Relevancy</p> | ||||||
| "! File cloud relevancy | ||||||
| is_cloud_relevant TYPE abap_bool, | ||||||
| END OF ty_sral_configuration. | ||||||
| "! <p class="shorttext">SRAL Configuration</p> | ||||||
| "! SRAL configuration | ||||||
| TYPES ty_sral_configurations TYPE SORTED TABLE OF ty_sral_configuration WITH UNIQUE KEY file_type. | ||||||
| TYPES: | ||||||
| "! <p class="shorttext">eDocument Type Specific Additional Tables</p> | ||||||
| "! eDocument type specific additional tables | ||||||
| BEGIN OF ty_additional_table, | ||||||
GuilhermeSaraiva96 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| "! <p class="shorttext">Sequence Number</p> | ||||||
| "! Sequence number | ||||||
| "! $required | ||||||
| sequence_number TYPE c LENGTH 10, | ||||||
| "! <p class="shorttext">Table Name</p> | ||||||
| "! Table name | ||||||
| "! $required | ||||||
| table_name TYPE zif_aff_types_v1=>ty_object_name_30, | ||||||
| END OF ty_additional_table. | ||||||
| "! <p class="shorttext">eDocument Type Specific Additional Tables</p> | ||||||
| "! eDocument type specific additional tables | ||||||
| TYPES ty_additional_tables TYPE SORTED TABLE OF ty_additional_table WITH UNIQUE KEY sequence_number. | ||||||
| TYPES: | ||||||
| "! <p class="shorttext">General Information</p> | ||||||
| "! General information | ||||||
| BEGIN OF ty_edoc_information, | ||||||
|
||||||
| BEGIN OF ty_edoc_information, | |
| BEGIN OF ty_general_information, |
Outdated
There was a problem hiding this comment.
Would you align the field names and the title's please?
Furthermore, is any field of general_information a $required field?
There was a problem hiding this comment.
unfortunately only name & description are manditory which are not part of gerneral information anymore.
There was a problem hiding this comment.
corrected the field names and labels
i506210 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
i506210 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
The field name is called sral_configuration, but the title is: Additional Selection Fields. These are not coherent, which would be best for the end user to understand what kind of field this is?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "AFF for eDocument Type (EDOT)", | ||
| "originalLanguage": "en" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having an example would also help me for the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow I am unable to generate example, I created class and Transformation but its not clear to me in the report what object to be mentioned as input.