Skip to content

feat: Add selective key exchange with pair command for secure peer connections#141

Open
Janmesh23 wants to merge 4 commits intoS4tvara:mainfrom
Janmesh23:feat/selective-key-exchange
Open

feat: Add selective key exchange with pair command for secure peer connections#141
Janmesh23 wants to merge 4 commits intoS4tvara:mainfrom
Janmesh23:feat/selective-key-exchange

Conversation

@Janmesh23
Copy link
Contributor

@Janmesh23 Janmesh23 commented Oct 18, 2025

Summary

This PR implements a selective key exchange system for enhanced P2P security in Sietch. It adds a new pair command that allows users to establish secure connections with specific peers, updates the discovery mechanism to support selective peer management, and enhances the sync functionality to work with the new key exchange system. The changes improve security by allowing users to control which peers they share data with, rather than syncing with all discovered peers.

AI Assistance

  • I used AI assistance (generate code, write tests, refactor, or docs)
    • Used AI assistance for implementing the pair command structure, updating the discovery logic for selective peer management, and enhancing the sync functionality to integrate with the new key exchange system. AI helped with code organization and ensuring proper integration between the new components.

Fixes #116

github-actions bot and others added 2 commits October 15, 2025 08:07
@github-actions
docs(contributor): contrib-readme-action has updated readme
43c73e1
@Janmesh23
feat: implement selective key exchange functionality
2cf000f 
- Add pair command for establishing secure connections
- Update discover command with enhanced peer discovery
- Modify sync command to support selective key exchange
- Update vault configuration for key management
- Enhance P2P sync with selective key exchange logic
- Improve UI prompts for better user experience
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2025

💡 Suggestions to Improve This PR

  • ❌ Missing or minimal explanation of changes

Consider addressing these points to make your contribution stronger. Thanks for contributing!

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 18, 2025
View reviewed changes
internal/ui/prompt.go
}

var minutes int
fmt.Sscanf(input, "%d", &minutes)

Check warning

Code scanning / gosec

Errors unhandled Warning

Errors unhandled
@codecov
Copy link

codecov bot commented Oct 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 1.86567% with 526 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/pair.go 4.32% 199 Missing ⚠️
internal/ui/prompt.go 0.00% 114 Missing ⚠️
internal/p2p/sync.go 0.00% 100 Missing ⚠️
cmd/discover.go 1.28% 77 Missing ⚠️
cmd/sync.go 0.00% 24 Missing ⚠️
internal/config/vault.go 0.00% 12 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Janmesh23
Copy link
Contributor Author

Janmesh23 commented Oct 18, 2025 •
edited
Loading

Hi @SubstantialCattle5 !!
i made changes in the way the peers where connecting , added flags , and tested the working of the feature
i just had one issue while commit , there was some test failing which was not related to the work i did and the scope it had , i tried solving it but couldn't get to solve it so i have pushed my work , it does not conflict with the current work and has its all tests passed !

i did the total test-coverage as well , it was all fine i guess .
do revert back with suggestions , thankyou .

edit - i saw the codecov report of missing testing of the added code , if tests are needed , please guide me as to how and what should i do exactly for

@S4tvara
Copy link
Owner

S4tvara commented Oct 19, 2025

Hi @Janmesh23 ,
Thank you for the PR. I'll review it soon and get back to you

@Janmesh23
Copy link
Contributor Author

Janmesh23 commented Oct 21, 2025 •
edited
Loading

Hi @SubstantialCattle5 , any updates ?
(also i wanted to ask whether you can create a tag like this for sietch which appears below our contributions heatmap , it'll be cool to have it 😅)
image

@S4tvara
Copy link
Owner

S4tvara commented Oct 22, 2025

Hi @SubstantialCattle5 , any updates ? (also i wanted to ask whether you can create a tag like this for sietch which appears below our contributions heatmap , it'll be cool to have it 😅) image

Hi @Janmesh23 ,

A bit busy with office work, i'll mark it as hacktoberfest accepted such that it counts towards your contributions.
Also the tags are shown when you contribute to a repo owned by an organization, since this is a personal repo there is no tag for it. If you wanna showcase this project I would suggest you to pin it in to your profile or add it on your resume.

@Janmesh23
Copy link
Contributor Author

Janmesh23 commented Oct 22, 2025

Hi @SubstantialCattle5 , any updates ? (also i wanted to ask whether you can create a tag like this for sietch which appears below our contributions heatmap , it'll be cool to have it 😅) image

Hi @Janmesh23 ,

A bit busy with office work, i'll mark it as hacktoberfest accepted such that it counts towards your contributions.
Also the tags are shown when you contribute to a repo owned by an organization, since this is a personal repo there is no tag for it. If you wanna showcase this project I would suggest you to pin it in to your profile or add it on your resume.

Yepp thanks

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

💡 Suggestions to Improve This PR

  • ❌ Missing or minimal explanation of changes

Consider addressing these points to make your contribution stronger. Thanks for contributing!

@Janmesh23
Remove duplicate Janmesh23's details from README
fef1fec 
Removed duplicate Janmesh23's information from the README.

my profile was visible twice on the README.md
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

💡 Suggestions to Improve This PR

  • ❌ Missing or minimal explanation of changes

Consider addressing these points to make your contribution stronger. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

hacktoberfest hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Selective Key Exchange for sietch discover

2 participants

@Janmesh23 @S4tvara