Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add board class similar to field but without the tuples #27

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add board class similar to field but without the tuples #27

wants to merge 5 commits into from

Conversation

freemansoft
Copy link
Contributor

Adding coordinate and other data structures.

S-ecki
S-ecki approved these changes Dec 3, 2024
View reviewed changes
Copy link
Owner

@S-ecki S-ecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Awesome that you also include tests!
Maybe we could get rid of the Field class from before so it is clear to users which class to use + change the name in the README

utils/board.dart Outdated Show resolved Hide resolved
@freemansoft freemansoft mentioned this pull request Dec 3, 2024
Open
@freemansoft freemansoft closed this Dec 5, 2024
@freemansoft
Copy link
Contributor Author

I'm iterating so will reopen in a day or two

@freemansoft freemansoft reopened this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-ecki S-ecki S-ecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freemansoft @S-ecki