cpufeatures: Disable all target features under miri #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-signal
force-pushed
the
cpufeatures-miri
branch
from
84ddd63 to
3bcd445
Compare
Miri is an interpreter, and though it tries to emulate the target CPU it does not support any target features.
jrose-signal
force-pushed
the
cpufeatures-miri
branch
from
3bcd445 to
fd401a1
Compare
jrose-signal
changed the title
|
Looks good now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
miri is an interpreter and doesn't support inline assembly. Fortunately, we already have precedent for an x86 target without cpuid: SGX. Treat miri like SGX: only features that are enabled at compile time are available at run time.miri is an interpreter, and though it tries to emulate the target CPU it does not support any target features.
Fixes #778.