Residue rename #485
Merged
Residue rename #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjarri
force-pushed
the
residue-rename
branch
from
644b474 to
81a76d9
Compare
|
Your description doesn't quite reflect the names, which are For the params names, I'd prefer Otherwise yes, we should get this rename done ASAP. |
fjarri
force-pushed
the
residue-rename
branch
from
f1b01fb to
0ee72d1
Compare
|
Renamed |
tarcieri
reviewed
Dec 20, 2023
tarcieri
reviewed
Dec 20, 2023
tarcieri
approved these changes
Dec 20, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351
Residue->ConstMontyFormDynResidue->MontyFormBoxedResidue->BoxedMontyForm*ResidueParams->*MontyParamsresidue_params->paramsparams.r->params.onePlease don't open other PRs before this one is merged, it's a pain to rebase.