Boxed uintlike coverage #428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuganyu96
force-pushed
the
boxed-uintlike-coverage
branch
from
e2819ce to
db33158
Compare
tarcieri
reviewed
Dec 15, 2023
src/modular/boxed_residue.rs
Outdated
Comment on lines
25
to
33
| let (half, is_odd) = a.shr1_with_carry(); | ||
| let half_modulus = modulus.shr1(); | ||
|
|
||
| let if_even = half.clone(); | ||
| let if_odd = half | ||
| .wrapping_add(&half_modulus) | ||
| .wrapping_add(&BoxedUint::one_with_precision(a.bits_precision())); | ||
|
|
||
| BoxedUint::conditional_select(&if_even, &if_odd, is_odd) |
There was a problem hiding this comment.
You can cut down on a number of allocations here:
Suggested change
| let (half, is_odd) = a.shr1_with_carry(); | |
| let half_modulus = modulus.shr1(); | |
| let if_even = half.clone(); | |
| let if_odd = half | |
| .wrapping_add(&half_modulus) | |
| .wrapping_add(&BoxedUint::one_with_precision(a.bits_precision())); | |
| BoxedUint::conditional_select(&if_even, &if_odd, is_odd) | |
| let (mut ret, is_odd) = a.shr1_with_carry(); | |
| let half_modulus = modulus.shr1(); | |
| let if_odd = ret | |
| .wrapping_add(&half_modulus) | |
| .wrapping_add(&BoxedUint::one()); | |
| ret.conditional_assign(&if_odd, is_odd); | |
| ret |
tarcieri
reviewed
Dec 15, 2023
Cargo.toml
Outdated
| @@ -39,7 +39,7 @@ rand_core = { version = "0.6", features = ["std"] } | |||
| rand_chacha = "0.3" | |||
|
|
|||
| [features] | |||
| default = ["rand"] | |||
| default = ["rand", "alloc"] | |||
There was a problem hiding this comment.
Most of the downstream crates which use this crate don't need the alloc feature. It's really just for rsa/dsa.
xuganyu96
force-pushed
the
boxed-uintlike-coverage
branch
from
8602622 to
b01e8bb
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to implement for
BoxedUintthe missing arithmetic needed forcrypto-primes(see entropyxyz/crypto-primes#37 (comment)).