Fix many of the Rust Clippy warnings and update Contributorship #20

akesling · 2020-12-07T18:55:46Z

See included commits for commentary on particular lints that this is resolving.

This continues toward bringing this library up to date with Rust style (#16)

See https://rust-lang.github.io/rust-clippy/master/#redundant_field_names

See https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

See https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if

See https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

See https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

See: 1) https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast 2) https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8

See https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

See https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl

https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats

…estructuring a single pattern. Consider using `if let` See https://rust-lang.github.io/rust-clippy/master/index.html#single_match

…instead See https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount

akesling added 12 commits December 7, 2020 13:47

Fix clippy redunant field names warning

afbe384

See https://rust-lang.github.io/rust-clippy/master/#redundant_field_names

Fix "length comparison to zero" clippy warnings

5a0f282

See https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

Fix clippy warning for collapsible if statement

2b0095d

See https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if

Fix clippy warning: statics have by default a 'static lifetime

b2e3f11

See https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

Fix clippy warning: useless use of format!

880f133

See https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

Fix clippy warnings about unnecessary literal casts

90aadb0

See: 1) https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast 2) https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8

Fix clippy warning: manual implementation of an assign operation

8d695e4

See https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

Fix clippy warning: re-implementing PartialEq::ne is unnecessary

cd07494

See https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl

Fix clippy warning: you don't need to add & to all patterns

573eacb

https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats

Fix clippy warning: warning: you seem to be trying to use match for d…

01e08e2

…estructuring a single pattern. Consider using `if let` See https://rust-lang.github.io/rust-clippy/master/index.html#single_match

Fix clippy error: read amount is not handled. Use Read::read_exact …

0fb7313

…instead See https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount

Update license and authors entries to reflect contribution copyright

0ed8d9d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix many of the Rust Clippy warnings and update Contributorship #20

Fix many of the Rust Clippy warnings and update Contributorship #20

Uh oh!

akesling commented Dec 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Fix many of the Rust Clippy warnings and update Contributorship #20

Are you sure you want to change the base?

Fix many of the Rust Clippy warnings and update Contributorship #20

Uh oh!

Conversation

akesling commented Dec 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant