Conversation
8beb627 to
dfed2b5
Compare
|
The CI failure for the WASM build seems unrelated to me. |
|
Hi, I've just merged #961. Could you confirm if the issue persists in the new Android backend and if yes, adjust the PR? |
I can confirm that this issue does still persist in the new Android backend. |
|
@Frando new maintainer here and doing some backlog grooming. Would you be so kind to resolve the conflicts, so we can work on getting the build to pass again, and get it merged? I see no negatives or regressions from going for this, or what would I be missing? |
@roderickvd this was fixed in #965 |
|
Fixed in #965 |
Currently the
Device::name()onoboehost (Android) only contains theoboe::AudioDeviceInfo::product_namestring. This is, however, identical for all internal audio devices.This PR changes this to add the
AudioDeviceTypeand, if present theaddress, which then gives an actually useful list of audio devices.List of device names before:
["Pixel 8", "Pixel 8", "Pixel 8", "Pixel 8", ...]List of devices names after
["Pixel 8:BuiltinEarpiece", "Pixel 8:BuiltinSpeaker", "Pixel 8:BuiltinMic:bottom", "Pixel 8:BuiltinMic:back", ...]