Skip to content

Conversation

@Decodetalkers
Copy link

because pipewire need it, so I want to upgrade it

@Decodetalkers Decodetalkers marked this pull request as draft January 7, 2026 11:46
@Decodetalkers Decodetalkers changed the title feat(edition): edition 2024 edition 2024 Jan 7, 2026
because pipewire need it, so I want to upgrade it
@roderickvd
Copy link
Member

roderickvd commented Jan 9, 2026

I'd like to keep cpal down to Rust 2021 for now, so we can keep the MSRV reasonably low.
For the pipewire crate, it should suffice to introduce a MSRV_PIPEWIRE and set it to 1.85.

@Decodetalkers
Copy link
Author

Decodetalkers commented Jan 9, 2026

I'd like to keep cpal down to Rust 2021 for now, so we can keep the MSRV reasonably low.
For the pipewire crate, it should suffice to introduce a MSRV_PIPEWIRE and set it to 1.85.

But we cannot set the edition into two versions according to the platform....

The min requirement for 2024 is rust 1.85

Ohh.. I see! Not edition 2024 is needed. That report is just the version of the compiler was too low! Thank you!

@roderickvd roderickvd closed this Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants