Extend Travis build matrix, patch SDL2 2.0.8 #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cobrand
reviewed
Sep 24, 2018
sdl2-sys/build.rs
Outdated
| #[cfg(feature = "bundled")] | ||
| fn patch_sdl2(sdl2_source_path: &Path) { | ||
| let patches: Vec<(&str, &'static str)> = vec
There was a problem hiding this comment.
Add as a comment why this patch is necessary, please (we probably won't remember in 6months, and we won't even be able to know when to remove it if/when this is fixed)
Doubles the number of builds, unfortunately, but it should cover all the common linkage scenarios, except for macos frameworks, which I'm not sure I know enough about to handle. Also autoformats travis.yml and splits the SDL archive extraction and installation out to a shell script
Assert that stereo buffers are *at least* twice the original size, rather than more than twice the size.
Using some very poorly tested file I/O code, it should be noted.
|
Sorry about the delay on these updates. I added a few comments, but please let me know if there are any other sections that could use some more clarifications. I also rebased onto master to pull in the update to version 2.0.2 of the sdl2 mixer. |
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
Extend Travis build matrix, patch SDL2 2.0.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a potential replacement for #781.
It keeps @reynisdrangar's original extension of the Travis build matrix, but it solves the OSX SDL2 2.0.8 build failure with some (questionable?) hand-crafted patching logic. See
patch_sdl2in sdl2-sys/build.rs and the new .patch file for the code new to this branch. All the other modifications are carried over from 781.This code is submitted as much for discussion is it is for actual adoption. The logic that's in the
patch_sdl2function should probably be backported into unidiff and throughly tested there, but for the moment -- until SDL2's CMake build system is fixed -- this may be a sufficient-enough stop-gap.