-
Notifications
You must be signed in to change notification settings - Fork 473
Ignore unrecognized keyboard modifiers #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes a crash when pressing any key on linux
Weird, I am on linux and everything works fine on my machine. I will merge this, but would you mind giving me the full details of how you discovered this, why do you think this happens and stuff like that ? This crash might have been raised when I refactored every |
Happened when I updated from 0.20.1 to 0.27.0 (sorry for the wide range) after a friend who was on 0.26-0.27 was having a crash on keypress (stack trace below). I ended up getting the same crash in
Both of us are on ubuntu x64 if it makes a difference. Edit: Happens on the examples |
Thanks for the stack trace, I will dig into this. The patch is up on crates.io as 0.27.1 for you and your friend |
Thanks. I should add we are both running nightly of rustc |
Even with
|
I just tried stable rustc and couldn't reproduce the issue but can with nightly every time after a single press. This might actually be a rustc bug?
|
Finally tracked down the actual issue and filed #579 |
Fixes a crash when pressing any key on linux.
Not completely sure why linux has something extra here (doesn't seem visible in sdl2's source) but I wasn't the only one with this issue.