Fixed references to std::c_str #268
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-lang/rust#20444 removed std::c_str and moved CString to std::ffi.
|
Just FYI @nukep and I are working on a patch which fixes this, plus the CVec stuff, and also cleans up the audio subsystem. See drbawb/pull/2 It needs a little cleanup but it's almost ready to merge. |
|
@drbawb That's great! I'll close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the references to
std::c_str::CString, which was moved tostd::ffi::CStringin rust-lang/rust#20444.Note that this change in Rust also removed
std::c_vecwithout a replacement. Sadly, I don't know the code well enough to create a suitable workaround. This is why the build is still failing.