Make read_clock_khr always available
#310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
read_shader_clock_feature
branch
from
bc8d095 to
704358e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split out from #280 to get it merged sooner
Currently, the
arch::read_clock_khrfunction is hidden behind it'starget_featuregatesShaderClockKHRandext:SPV_KHR_shader_clock, unlike every other intrinsic we have. Usually, the functions are always available andspirv-valjust fails if you use a feature without enabling it. This PR removes the feature gate.It also removes that extension and capability from the ones enabled by default in compiletest, as naga does not support it, to unblock #280