Skip to content

add targets vulkan1.3, vulkan1.4 and spv1.6 #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Jun 4, 2025

Requires #279, Rust-GPU/spirv-tools-rs#11

I thought it'll be easy going, but it seems like spv1.6 introduced some new validation we're now failing. Nope, just some tests excluded for vulkan that need their target list extended.

@Firestar99
Copy link
Member Author

Firestar99 commented Jun 10, 2025

Compiletest fails due to the installed tools being too old and not knowing what vulkan1.4 is.

Current CI downloads a pre-build version of spirv tools from Embark's spirv-tools repo, specifically release 0.10.0, which includes some pre-build *.tar.zstd blobs. Supposedly I could just trigger the "Precompile spirv-tools binaries" Action but that one has been broken likely by basel updating something. @LegNeato tried fixing it on master, but no luck so far.

Some Options we have to fix this:

  1. fixup bazal build and publish a new set of pre-builds
  2. grab the binaries from lunarg, the official source and get rid of bazel
  3. derp some blobs together on my local machine, but I can't do Mac
  4. recompile on CI every time, too slow IMO

I'm considering trying out 2 tomorrow, or do you @LegNeato have a better idea?

This also unblocks #258

@Firestar99 Firestar99 marked this pull request as ready for review June 11, 2025 10:15
@Firestar99 Firestar99 marked this pull request as draft June 11, 2025 10:16
@Firestar99
Copy link
Member Author

@LegNeato This is effectively ready to review, it just requires #279 and spirv-tools-rs PR Rust-GPU/spirv-tools-rs#11 to be merged and released on crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant