-
Notifications
You must be signed in to change notification settings - Fork 188
llvm 19 support #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm 19 support #227
Conversation
i'm on the fence about renaming i think it might not actually be needed and i might put it back |
@LegNeato my measuring stick here is does could you tell me if I'm close or if I'm actually missing something huge like a mountain of work I'm not seeing? |
pain |
I don't know, llvm is an area of the project I have not touched. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should stay the same, right? The newer support should be optional / only enabled when
static PREBUILT_LLVM_URL: &str = | ||
"https://github.com/rust-gpu/rustc_codegen_nvvm-llvm/releases/download/LLVM-7.1.0/"; | ||
|
||
static REQUIRED_MAJOR_LLVM_VERSION: u8 = 7; | ||
static REQUIRED_MAJOR_LLVM_VERSION: u8 = 19; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requirement doesn't bump unless targeting a higher arch? So the logic is:
- 7 if targeting arch supported by 7 and 19
- 19 if targeting arch not supported by 7
We should probably break this down, seeing as neither of us understand this space. First, we should probably add various values for arch and stuff to enums on the rust side. Some of these might need to be gated if on 7 vs 19. Then, we should get switching between 7 and a stubbed out / non working 19 via target arch. Then, we should systematically fix each issue and refactor common code on the way. |
ok... kind of a strange remark... i'm just going to work on my local branch and make kernels compile with 19.1 then i was going to work backwards and "make it upstream worthy"... |
potentially addresses all of:
Update rustc_llvm_wrapper to optionally support LLVM v19 #226 (Updates rustc_llvm_wrapper)
GitHub Codespaces/VSCode Devcontainer support #224 (Adds Codespaces, optional, we could remove)
sha2 crate = runtime error #207 (if LLVM v19 will compile and not have same issues as LLVM v7)
CUDA 12.8.1 and LLVM 18.1.8 #197 (we can put this behind a feature flag to optionally support Blackwell+)