Skip to content

dockerfile: Install cargo-gccrs alongside gccrs #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2022
Merged

dockerfile: Install cargo-gccrs alongside gccrs #937

merged 1 commit into from
Feb 16, 2022

Conversation

CohenArthur
Copy link
Member

Closes #826

@philberty philberty added this to the Macro Expansion milestone Feb 16, 2022
@philberty
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 16, 2022

Build succeeded:

@bors bors bot merged commit a5272f3 into Rust-GCC:master Feb 16, 2022
CohenArthur added a commit to CohenArthur/gccrs that referenced this pull request Feb 17, 2022
@bors @CohenArthur
Merge Rust-GCC#934 Rust-GCC#937
5762177 
934: macromatch: Add location to abstract MacroMatch class r=philberty a=CohenArthur

Closes Rust-GCC#928

This adds location to the all child classes of the `MacroMatch` abstract class. The current locations are as follow, which I believe is what is expected but might be wrong.

```rust
test.rs:2:6: error: macro match fragment
    2 |     ($a:expr, $b:expr) => { $a + $b };
      |      ^
test.rs:2:15: error: macro match fragment
    2 |     ($a:expr, $b:expr) => { $a + $b };
      |               ^
test.rs:2:5: error: macro matcher
    2 |     ($a:expr, $b:expr) => { $a + $b };
      |     ^
test.rs:3:8: error: macro match fragment
    3 |     ($($i:ident)*) => { $($i)* }
      |        ^
test.rs:3:17: error: macro match repetition!
    3 |     ($($i:ident)*) => { $($i)* }
      |                 ^
test.rs:3:5: error: macro matcher
    3 |     ($($i:ident)*) => { $($i)* }
      |     ^
```

I think this should be rebased on Rust-GCC#932 so that I can remove the FIXME

937: dockerfile: Install cargo-gccrs alongside gccrs r=philberty a=CohenArthur

Closes Rust-GCC#826

Co-authored-by: Arthur Cohen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philberty philberty philberty approved these changes

Assignees
No one assigned
Labels
automation
Projects
None yet
Milestone
Macro Expansion
Development

Successfully merging this pull request may close these issues.

Docker file for GCCRS and Cargo-gccrs
2 participants
@CohenArthur @philberty