gccrs: Emit error when tuple-indexing on non-tuples #4205
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowr
force-pushed
the
fix/tuple-index-reject-non-tuple
branch
from
ee531b7 to
269ec48
Compare
Fixes Rust-GCC#3927 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): check and properly emit an error when the tuple index is on a non-tuple-struct. gcc/testsuite/ChangeLog: * rust/compile/tuple_index_on_non_tuple.rs: New test. Signed-off-by: Ryo Yoshida <[email protected]>
lowr
force-pushed
the
fix/tuple-index-reject-non-tuple
branch
from
269ec48 to
3dbc08f
Compare
|
Not a big deal, but the doc change for clang-format version could be split in a different PR. |
|
Sure, I'll drop the second commit and submit another PR then :) |
lowr
force-pushed
the
fix/tuple-index-reject-non-tuple
branch
from
3dbc08f to
6fea702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3927
This PR fixes type checking on tuple indexing expressions by properly emitting errors when the tuple operand of the expression is not tuple-like instead of an assertion that was causing the reported panic. Although not reported by the issue, I also found that the previous code allowed tuple indexing on structs, so I added a test case to assert such expressions also cause compilations to fail with an appropriate error message.
In addition, I fixed the clang-format version to use in CONTRIBUTING.md. Let me know if the commit should be in a separate PR since it's irrelevant to #3927.