Skip to content

Conversation

dkm
Copy link
Member

@dkm dkm commented Sep 22, 2025

This new workflow is used to send emails to the gcc-patches@ mailing list after every merged PR.

For each merged PR:

  • remove commits touching files not to-be-upstreamed (e.g. github workflow, README.md, ...)
  • if the number of commit is 1, send a single email and add a header explaining what this is about, a link to the PR, ...
  • if the number of commits is > 1, then create a cover letter and put the header there.

Authors of commits will be put in Cc: of emails.

Configure it by setting the following secrets in github:

  • PATCH_TO: the "To:" field for the emails
  • PATCH_CC: optional "Cc:"
  • SMTP_FROM, SMTP_PASSWORD, SMTP_PORT, SMTP_SERVER, STMP_USERNAME: self explanatory

@dkm dkm requested a review from CohenArthur September 22, 2025 21:14
@dkm dkm self-assigned this Sep 22, 2025
@dkm dkm added CI upstream Issue regarding upstreaming gccrs into GCC labels Sep 22, 2025
@dkm
Copy link
Member Author

dkm commented Sep 22, 2025

(I should have already correctly setup the test values for configuring the workflow => the last thing to try it is to merge this PR)

Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM looking forward to seeing our patches in gcc-patches regularly now

@dkm
Copy link
Member Author

dkm commented Sep 22, 2025

As a first step, I'll be receiving all the emails. Let's wait a bit before really spa^Wsending emails to gcc ml 😅

@philberty
Copy link
Member

I thinjk the only issue is if we have a PR for like a sync from upstream but i think we should just push that directly to master would get around that.

@philberty
Copy link
Member

philberty commented Sep 22, 2025

Or we have a filter for only emit emails for stuff that touches gcc/rust or gcc/testsuite/rust or libgrust stuff

@dkm
Copy link
Member Author

dkm commented Sep 22, 2025

Yes, sync are pushed directly so should not trigger the workflow 🤞

@philberty
Copy link
Member

But lets just see whats this is like in my opinion.. comment spam :P

@dkm
Copy link
Member Author

dkm commented Sep 22, 2025

Or we have a filter for only emit emails for stuff that touches gcc/rust or gcc/testsuite/rust or libgrust stuff

Hmmm, this can be done. I'm already dropping commit touching files that should not be sent to gcc. We could also check we only send for stuff touching actual rust stuff

This new workflow is used to send emails to the gcc-patches@ mailing list
after every merged PR.

For each merged PR:
- remove commits touching files not to-be-upstreamed (e.g. github
workflow, README.md, ...)
- if the number of commit is 1, send a single email and add a header
explaining what this is about, a link to the PR, ...
- if the number of commits is > 1, then create a cover letter and put
the header there.

Authors of commits will be put in Cc: of emails.

Configure it by setting the following secrets in github:
- PATCH_TO: the "To:" field for the emails
- PATCH_CC: optional "Cc:"
- SMTP_FROM, SMTP_PASSWORD, SMTP_PORT, SMTP_SERVER, STMP_USERNAME: self explanatory

ChangeLog:

	* .github/workflows/send-emails.yml: New file.
@dkm dkm enabled auto-merge September 23, 2025 08:39
@dkm dkm added this pull request to the merge queue Sep 23, 2025
Merged via the queue into master with commit 094ca2b Sep 23, 2025
13 checks passed
@dkm dkm deleted the pr/ci_send_email branch September 23, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI upstream Issue regarding upstreaming gccrs into GCC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants