-
Notifications
You must be signed in to change notification settings - Fork 191
ci: new workflow for sending emails after merging a PR #4184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(I should have already correctly setup the test values for configuring the workflow => the last thing to try it is to merge this PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM looking forward to seeing our patches in gcc-patches regularly now
As a first step, I'll be receiving all the emails. Let's wait a bit before really spa^Wsending emails to gcc ml 😅 |
I thinjk the only issue is if we have a PR for like a sync from upstream but i think we should just push that directly to master would get around that. |
Or we have a filter for only emit emails for stuff that touches gcc/rust or gcc/testsuite/rust or libgrust stuff |
Yes, sync are pushed directly so should not trigger the workflow 🤞 |
But lets just see whats this is like in my opinion.. comment spam :P |
Hmmm, this can be done. I'm already dropping commit touching files that should not be sent to gcc. We could also check we only send for stuff touching actual rust stuff |
This new workflow is used to send emails to the gcc-patches@ mailing list after every merged PR. For each merged PR: - remove commits touching files not to-be-upstreamed (e.g. github workflow, README.md, ...) - if the number of commit is 1, send a single email and add a header explaining what this is about, a link to the PR, ... - if the number of commits is > 1, then create a cover letter and put the header there. Authors of commits will be put in Cc: of emails. Configure it by setting the following secrets in github: - PATCH_TO: the "To:" field for the emails - PATCH_CC: optional "Cc:" - SMTP_FROM, SMTP_PASSWORD, SMTP_PORT, SMTP_SERVER, STMP_USERNAME: self explanatory ChangeLog: * .github/workflows/send-emails.yml: New file.
1242606
to
adcc199
Compare
This new workflow is used to send emails to the gcc-patches@ mailing list after every merged PR.
For each merged PR:
Authors of commits will be put in Cc: of emails.
Configure it by setting the following secrets in github: