gccrs: Fix ICE handling division by zero in const eval #4172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls over more constexpr support from C++ front-end. Fixes #4146 gcc/rust/ChangeLog: * backend/rust-constexpr.cc (eval_constant_expression): port over missing bits (eval_store_expression): likewise (eval_call_expression): likewise (eval_binary_expression): likewise (eval_bit_field_ref): likewise (eval_check_shift_p): likewise (fold_pointer_plus_expression): likewise (maybe_fold_addr_pointer_plus): likewise (fold_expr): likewise (union_active_member): likewise (fold_indirect_ref_1): likewise (rs_fold_indirect_ref): likewise (rs_eval_indirect_ref): likewise (eval_logical_expression): likewise (eval_vector_conditional_expression): likewise (eval_bare_aggregate): likewise (cxx_eval_trinary_expression): likewise (eval_and_check_array_index): likewise (eval_array_reference): likewise (eval_component_reference): likewise (rs_bind_parameters_in_call): likewise (eval_builtin_function_call): likewise (constexpr_fn_retval): likewise (verify_constant): likewise (get_array_or_vector_nelts): likewise (eval_conditional_expression): likewise (eval_switch_expr): likewise (eval_unary_expression): likewise (cxx_eval_outermost_constant_expr): likewise (potential_constant_expression_1): likewise gcc/testsuite/ChangeLog: * rust/compile/issue-2394.rs: Update test case * rust/compile/issue-4146.rs: New test. Signed-off-by: Philip Herron <[email protected]>
philberty
force-pushed
the
phil/const-crash
branch
from
cf6c3ec to
81e274a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls over more constexpr support from C++ front-end.
Fixes #4146
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: