-
Notifications
You must be signed in to change notification settings - Fork 191
tests: added extra parens compile test #4137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the contribution @0xllx0! Your test is correct but unfortunately gccrs parses it as a trait and does the wrong thing, and errors out 😬 could you create an issue for this? You can also work on fixing it within this PR if you want |
How do I get the test to fail then? That's what I was expecting, but marking it as a "should fail" test didn't feel right, as the test is expected to eventually pass, but should fail now. I opened a tracking issue for the test mismatch: #4148 I'd be happy to work on the fix in this PR. |
6091795
to
d02e94f
Compare
I think I figured out the problem, just needed to add |
If |
Alright, so while the ICE exists, mark this test as |
51bef28
to
7ec196a
Compare
Adds a test to verify extra parentheses are discarded, and the source is compiled as expected. Resolves: Rust-GCC#2886 gcc/testsuite/ChangeLog: * rust/compile/issue-4148.rs: New test. Signed-off-by: Elle Rhumsaa <[email protected]>
7ec196a
to
9c96a5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good, thank you!
Adds a test to verify extra parentheses are discarded, and the source is compiled as expected.
Resolves: #2886, #4148
Thank you for making Rust GCC better!
If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.
Here is a checklist to help you with your PR.
make check-rust
passes locallyclang-format
gcc/testsuite/rust/
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
*Please write a comment explaining your change. This is the message
that will be part of the merge commit.