gccrs: feat: Made changes to ensure no wrong assignments are done.

[sriganeshres]

gcc/rust/ChangeLog:

* backend/rust-compile-expr.cc (lvalue_p): Created a function that checks the lvalue. (CompileExpr::visit): Modified the function to check the lvalue using the above mentioned function and also checks the type of lvalue expression.

gcc/testsuite/ChangeLog:

* rust/compile/issue-3287.rs: New test for testing wrong assignments.

Fixes #3287

• GCC development requires copyright assignment or the Developer's Certificate of Origin sign-off, see https://gcc.gnu.org/contribute.html or https://gcc.gnu.org/dco.html
• Read contributing guidlines
• make check-rust passes locally
• Run clang-format
• Added any relevant test cases to gcc/testsuite/rust/

[philberty]

There are changes required here i think we can get away wit this check but not totally convinced yet

Also it will need to be applied to the other assignments such as:

x +=1 etc

[sriganeshres]

There are changes required here i think we can get away wit this check but not totally convinced yet

Also it will need to be applied to the other assignments such as:

x +=1 etc

Can you give me more information about the case we are missing as x+= 1 is valid as long as x is mutable in rust.

[powerboat9]

There are changes required here i think we can get away wit this check but not totally convinced yet
Also it will need to be applied to the other assignments such as:
x +=1 etc

Can you give me more information about the case we are missing as x+= 1 is valid as long as x is mutable in rust.

You have to adjust the visitor for CompoundAssignmentExpr as well as the visitor for AssignmentExpr

[powerboat9]

Would probably be good to make lvalue_p operate on HIR nodes instead of trees

[CohenArthur]

could you add a testcase like this one?

fn main() {
    15 = 14;
}

[philberty]

LGTM but i think you need to change that test case

[philberty]

Yeah this is good but yeah arthur has some minor comments too which need done.

[sriganeshres]

I guess they failing now because of newer tests. If this this merged with upstream there will not be as issue-3147.rs file is added after this changes.

[philberty]

You need to rebase you code and investigate why you have failing tests.