Merged
Conversation
10 tasks
tamaroning
force-pushed
the
uc-hangul
branch
2 times, most recently
from
50f12e7 to
35ad3c5
Compare
CohenArthur
approved these changes
Jul 27, 2023
Comment on lines
+231
to
+232
| // int starter_pos = 0; // Assume the first character is Starter. Correct? | ||
| // int target_pos = 1; |
Member
|
@tamaroning once the conflicts are fixed, I'll merge this PR :) |
gcc/rust/ChangeLog: * util/rust-unicode.cc (decomp_cano): Decompose Hangul. (sort_cano): Fix bounds check. (recomp): use `compose_hangul`. (compose_hangul): Compose Hangul. (rust_utf8_normalize_test): Add tests. Signed-off-by: Raiki Tamura <tamaron1203@gmail.com>
Contributor
Author
|
@CohenArthur It's ready to merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2379
depends on PR #2425
More tests will be added in another PR.
See: Sample Code for Hangul Algorithms
https://www.unicode.org/versions/Unicode15.0.0/ch03.pdf