Fix lexing byte literal #2320
Merged
Fix lexing byte literal #2320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philberty
approved these changes
Jun 25, 2023
tamaroning
force-pushed
the
fix-byte-literal
branch
from
857c8a7 to
0e4409c
Compare
gcc/rust/ChangeLog: * lex/rust-lex.cc (Lexer::parse_byte_char):add check for range of codepoint gcc/testsuite/ChangeLog: * rust/compile/bytecharstring.rs:add test for it Signed-off-by: Raiki Tamura <[email protected]>
tamaroning
force-pushed
the
fix-byte-literal
branch
from
0e4409c to
3c3f2b2
Compare
|
@philberty Thank you for your review :) Rebased now. |
|
@CohenArthur Could you rerun tests also for this pr? |
|
done @tamaroning :) I wonder why it kept failing. I think github was having some server issues. I hope it runs properly this time. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2308
NOTE: this pr depends on (includes commit from) PR #2307
so please merge this after PR #2307 is merged