Don't ICE on traits' Self generic parameters
#1135
Conversation
|
|
||
| // FIXME: This fails lookup on the `Self` generic parameter of the | ||
| // trait definition. We can skip it for now, but that's not a real fix | ||
| if (!ok) |
There was a problem hiding this comment.
This is interesting you should put a debug line in to see what the ID is here and compare with what it is over in rust-hir-trait-resolve.h line 138 and ou should be able to call self->debug() we might be missing an insert call
There was a problem hiding this comment.
in fact yes these are likely not getting inserted at all
The `Self` type of a Trait is part of its generic parameter list. This fails lookup since it's not a properly defined type. We need to be able to identify `Self` parameters and skip them in the reachability pass. Co-authored-by: philberty <[email protected]>
CohenArthur
force-pushed
the
1128-ice-reachability-pass
branch
from
4f3c252 to
ebf3032
Compare
|
I've found the real issue here the fix is simple but it causes a regression in using qualified paths within traits since there is no associated impl block its working by accident right now the relevant test case is gcc/testsuite/rust/execute/torture/trait3.rs. Do you mind if I take this over? |
Great! Nice find. I had completely forgotten about this and was neck-deep in simple path resolving haha
Please do! The only interesting thing in this PR is the test case, so you can close it whenever you want |
|
This will be fixed as part of #1190 |
The
Selftype of a Trait is part of its generic parameter list. Thisfails lookup since it's not a properly defined type. We need to be able
to identify
Selfparameters and skip them in the reachability pass.Closes #1128