Skip to content

Docker file for GCCRS and Cargo-gccrs #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philberty opened this issue Dec 8, 2021 · 0 comments · Fixed by #937
Closed

Docker file for GCCRS and Cargo-gccrs #826

philberty opened this issue Dec 8, 2021 · 0 comments · Fixed by #937
Assignees

Comments

@philberty
Copy link
Member

Now that we have cargo-gccrs we should update our Dockerfile (https://github.com/Rust-GCC/gccrs/blob/0024bc2f028369b871a65ceb11b2fddfb0f9c3aa/Dockerfile) to install cargo-gccrs https://github.com/Rust-GCC/cargo-gccrs

This dockerfile will allow us to use github automation for testing upon bors merge to master to run our #682 no_core blake project

@bors bors bot closed this as completed in #937 Feb 16, 2022
@bors bors bot closed this as completed in a5272f3 Feb 16, 2022
CohenArthur added a commit to CohenArthur/gccrs that referenced this issue Feb 17, 2022
934: macromatch: Add location to abstract MacroMatch class r=philberty a=CohenArthur

Closes Rust-GCC#928

This adds location to the all child classes of the `MacroMatch` abstract class. The current locations are as follow, which I believe is what is expected but might be wrong.

```rust
test.rs:2:6: error: macro match fragment
    2 |     ($a:expr, $b:expr) => { $a + $b };
      |      ^
test.rs:2:15: error: macro match fragment
    2 |     ($a:expr, $b:expr) => { $a + $b };
      |               ^
test.rs:2:5: error: macro matcher
    2 |     ($a:expr, $b:expr) => { $a + $b };
      |     ^
test.rs:3:8: error: macro match fragment
    3 |     ($($i:ident)*) => { $($i)* }
      |        ^
test.rs:3:17: error: macro match repetition!
    3 |     ($($i:ident)*) => { $($i)* }
      |                 ^
test.rs:3:5: error: macro matcher
    3 |     ($($i:ident)*) => { $($i)* }
      |     ^
```

I think this should be rebased on Rust-GCC#932 so that I can remove the FIXME

937: dockerfile: Install cargo-gccrs alongside gccrs r=philberty a=CohenArthur

Closes Rust-GCC#826

Co-authored-by: Arthur Cohen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants