Repository navigation
fix: backgrounded tunnel no longer holds the caller's output open - #2
Merged
Merged
Conversation
ssh -f kept the stdout and stderr of rzv-openhands-backend, so a pipe reading its output (the backend e2e's grep | tee) never ended after up succeeded. Redirect the tunnel's stdio; its messages go to <state>/<sandbox-id>.tunnel.log. The e2e filters with --line-buffered. Signed-off-by: Ditah Kumbong <ditah.kumbong@runzivo.dev>
…onnect Signed-off-by: Ditah Kumbong <ditah.kumbong@runzivo.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Runzivo/rzv-platform#146
ssh -f(and the rzv ProxyCommand under it) inherited the helper's stdout/stderr, so any pipe readingrzv-openhands-backend upoutput never reached EOF. The shared backend e2e hung after a successfulup(tunnel and /health were fine). The tunnel now runs with</dev/null >/dev/null 2>>$STATE/<id>.tunnel.log,downremoves that log, and the e2e filters withgrep --line-buffered.