New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain the existing panic_hook onto Rollbar reporting #20

Open

shaunrs wants to merge 2 commits into RoxasShadow:master from shaunrs:chained_panic_handler

shaunrs commented Oct 13, 2022 •

edited

Loading

Currently the macro report_panics! works just fine, but it replaces the default panic hook.

This causes a number of issues:

No feedback on the console once rollbar is enabled, which is the default expected behaviour for panic!
A custom panic_hook that is in place before rollbar is called will no longer be called

This PR fixes that by chaining the original panic hook on the end of rollbar reporting.

shaunrs added 2 commits

October 13, 2022 17:12


          Chain the existing panic_hook onto Rollbar reporting

b41df42


          Bump version to 0.7.1

b5ffe3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet