fix: disable native tools for Gemini models in OpenAI compatible provider #9387
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ider When using Gemini models via OpenAI Compatible provider, they do not support native OpenAI tool calling format and require XML-style tool calls instead. This fix detects Gemini models by their model ID and disables supportsNativeTools to force XML protocol. Fixes #9385
dosubot
bot
added
size:XS
Contributor
Author
Review completed. The fix correctly detects Gemini models and disables native tool support, but test coverage is needed.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Comment on lines
+319
to
+323
| // Gemini models don't support native OpenAI tool calling format when accessed via OpenAI Compatible endpoints | ||
| // They require XML-style tool calls instead | ||
| if (id.toLowerCase().includes("gemini")) { | ||
| info = { ...info, supportsNativeTools: false } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This new Gemini detection logic lacks test coverage. The fix should include tests verifying that models with 'gemini' in their ID (case-insensitive) have supportsNativeTools set to false, while other models are unaffected. This is especially important since the issue report indicates this is a regression from v3.33.0 to v3.33.1.
Fix it with Roo Code or mention @roomote and request a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where Gemini models accessed via OpenAI Compatible provider were incorrectly attempting to use native OpenAI tool calling format, which they don't support. The fix detects Gemini models by their model ID and disables native tool support, forcing them to use XML-style tool calls instead.
Problem
Starting with v3.33.1, when native tool calling support was added to the OpenAI-compatible provider, Gemini models stopped working correctly. They would output valid XML tool calls, but these would not be recognized or executed because the system was expecting native format instead.
Solution
The fix checks if the model ID contains 'gemini' (case-insensitive) and overrides the flag to , ensuring these models use the XML protocol for tool calls.
Testing
RUN v3.2.4 /data/repos/Roo-Code
Test Files 1 failed (1)
Tests no tests
Start at 08:10:47
Duration 1.51s (transform 665ms, setup 0ms, collect 0ms, tests 0ms, environment 0ms, prepare 113ms)
Fixes #9385