-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Make checkpoint on new task #3834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi again @samhvw8, Overall I think this is a great idea, many times I wanted to revert the changes made by a subtask only to find out there was no checkpoint. |
Yes, agree, i will update my code tmr 💪🏻
…On Thu, 22 May 2025 at 23:40 Daniel ***@***.***> wrote:
*daniel-lxs* left a comment (RooCodeInc/Roo-Code#3834)
<#3834 (comment)>
Hi again @samhvw8 <https://github.com/samhvw8>,
Do you think it makes sense to add a new unit test to
ShadowCheckpointService.test.ts for the force empty commit behavior?
—
Reply to this email directly, view it on GitHub
<#3834 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7VCZR356RBMVVUUZFQPAT27X4YVAVCNFSM6AAAAAB5WKIUCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMBRHA4TENJUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@cte Can we please merge this for now? this functionality of checkpoints with orchestrator is not useful. This would be far better than the current state of things and we don't have the time for a more complex solution at the moment. |
Yes, I think we can merge it after it goes through code review, though as I mentioned before this isn't the way I want to solve this problem, so fair warning that there's a chance that I will revert this and re-implement it later. |
Ensures that invoking the `newTaskTool` always creates a checkpoint, even if no files have changed. This provides a consistent state snapshot before a sub-task is initiated.
10535b4
to
b518212
Compare
@daniel-lxs Roo help me added test, can you check it |
Ensures that invoking the
newTaskTool
always creates a checkpoint, even if no files have changed. This provides a consistent state snapshot before a sub-task is initiated.Related GitHub Issue
Closes: #
Description
Test Procedure
Type of Change
src
or test files.Pre-Submission Checklist
npm run lint
).console.log
) has been removed.npm test
).main
branch.npm run changeset
if this PR includes user-facing changes or dependency updates.Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Ensure
newTaskTool
creates a checkpoint even if no files change by forcing empty commits.newTaskTool
innewTaskTool.ts
now callscheckpointSave
withforce=true
to ensure a checkpoint is created even if no files have changed.checkpointSave
inindex.ts
updated to accept aforce
parameter, allowing empty commits.saveCheckpoint
inShadowCheckpointService.ts
updated to handleallowEmpty
option for empty commits.newTaskTool.ts
.This description was created by
for 10535b4. You can customize this summary. It will automatically update as commits are pushed.