Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jan 7, 2026

Related GitHub Issue

Closes: #10071

Description

This PR attempts to address Issue #10071 by enabling thinking mode support for DeepSeek V3.1 on the Fireworks AI provider.

Changes:

  • Added supportsReasoningBinary: true flag to the deepseek-v3p1 model definition in the Fireworks provider configuration
  • Updated corresponding test to verify the new flag is present

How it works:
When the model has supportsReasoningBinary: true and the user enables reasoning in the API options, the provider will pass thinking: { type: "enabled" } parameter to the Fireworks API, which triggers the reasoning/thinking mode for DeepSeek V3.1.

Feedback and guidance are welcome.

Test Procedure

  1. Ran Fireworks provider tests: cd src && npx vitest run api/providers/__tests__/fireworks.spec.ts - All 28 tests passed
  2. Ran type checking: cd packages/types && npx tsc --noEmit - No type errors
  3. Lint checks passed during commit

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

  • No documentation updates are required.

Additional Notes

This is a new PR as requested by @hannesrudolph. The fix adds the supportsReasoningBinary capability flag to DeepSeek V3.1 model based on user confirmation that Fireworks documentation supports thinking/reasoning mode for this model via API parameter.


Important

Adds reasoning mode support to DeepSeek V3.1 model in Fireworks AI by setting supportsReasoningBinary: true.

  • Behavior:
    • Adds supportsReasoningBinary: true to deepseek-v3p1 in fireworks.ts to enable reasoning mode.
    • When reasoning is enabled in API options, passes thinking: { type: "enabled" } to Fireworks API.
  • Tests:
    • Updates test in fireworks.spec.ts to check for supportsReasoningBinary: true in deepseek-v3p1 model configuration.

This description was created by Ellipsis for 7e011e3. You can customize this summary. It will automatically update as commits are pushed.

@roomote
Copy link
Contributor Author

roomote bot commented Jan 7, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues identified.

The PR correctly adds supportsReasoningBinary: true to enable thinking mode for DeepSeek V3.1 on Fireworks AI. The implementation follows existing patterns and tests are properly updated.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[BUG] Thinking mode for DeepSeek V3.1 on Fireworks AI provider is not working.

3 participants