Skip to content

add back deterministic streamer mode #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add back deterministic streamer mode #32

wants to merge 1 commit into from

Conversation

@Kaiyotech
Copy link
Contributor

No description provided.

@Rolv-Arild
Copy link
Owner

Is this still a missing feature?

@Kaiyotech
Copy link
Contributor Author

Sort of. Mine is a parameter I can turn on and off, the version in main is always deterministic if streaming I think.

@Rolv-Arild
Copy link
Owner

Actually the check is for streamer_mode > 1, so it is still an option, although definitely a bit obscure.
https://github.com/Rolv-Arild/rocket-learn/blob/master/rocket_learn/rollout_generator/redis/redis_rollout_worker.py#L385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kaiyotech @Rolv-Arild