fix pylint

Author: Gui-FernandesBR

tests/integration/simulation/test_flight.py

@@ -717,32 +717,8 @@ def invalid_controller_9_params(  # pylint: disable=unused-argument
         )
 
 
-def test_environment_methods_accessible_in_controller(
-    calisto_robust, example_plain_env
-):
-    """Test that all environment methods are accessible within the controller.
-
-    This test verifies that the environment object passed to the controller
-    provides access to all necessary atmospheric and environmental data.
-
-    Parameters
-    ----------
-    calisto_robust : rocketpy.Rocket
-        Calisto rocket without air brakes
-    example_plain_env : rocketpy.Environment
-        Environment object for the simulation
-    """
-    # Track which environment methods were successfully called
-    methods_called = {
-        "elevation": False,
-        "wind_velocity_x": False,
-        "wind_velocity_y": False,
-        "speed_of_sound": False,
-        "pressure": False,
-        "temperature": False,
-    }
-
-    def _call_env_methods(environment, altitude_asl, methods_called):
+def make_controller_test_environment_access(methods_called):
+    def _call_env_methods(environment, altitude_asl):
         _ = environment.elevation
         methods_called["elevation"] = True
         _ = environment.wind_velocity_x(altitude_asl)
@@ -756,7 +732,7 @@ def _call_env_methods(environment, altitude_asl, methods_called):
         _ = environment.temperature(altitude_asl)
         methods_called["temperature"] = True
 
-    def controller_test_environment_access(  # pylint: disable=unused-argument
+    def controller(  # pylint: disable=unused-argument
         time,
         sampling_rate,
         state,
@@ -773,18 +749,48 @@ def controller_test_environment_access(  # pylint: disable=unused-argument
             return None
 
         try:
-            _call_env_methods(environment, altitude_asl, methods_called)
+            _call_env_methods(environment, altitude_asl)
             air_brakes.deployment_level = 0.3
         except AttributeError as e:
             raise AssertionError(f"Environment method not accessible: {e}") from e
 
         return (time, air_brakes.deployment_level)
 
+    return controller
+
+
+def test_environment_methods_accessible_in_controller(
+    calisto_robust, example_plain_env
+):
+    """Test that all environment methods are accessible within the controller.
+
+    This test verifies that the environment object passed to the controller
+    provides access to all necessary atmospheric and environmental data.
+
+    Parameters
+    ----------
+    calisto_robust : rocketpy.Rocket
+        Calisto rocket without air brakes
+    example_plain_env : rocketpy.Environment
+        Environment object for the simulation
+    """
+    # Track which environment methods were successfully called
+    methods_called = {
+        "elevation": False,
+        "wind_velocity_x": False,
+        "wind_velocity_y": False,
+        "speed_of_sound": False,
+        "pressure": False,
+        "temperature": False,
+    }
+
+    controller = make_controller_test_environment_access(methods_called)
+
     # Add air brakes with environment-testing controller
     calisto_robust.parachutes = []
     calisto_robust.add_air_brakes(
         drag_coefficient_curve="data/rockets/calisto/air_brakes_cd.csv",
-        controller_function=controller_test_environment_access,
+        controller_function=controller,
         sampling_rate=10,
         clamp=True,
     )