Refactor environment method access in controller test for clarity

Author: Gui-FernandesBR

tests/integration/simulation/test_flight.py

@@ -742,6 +742,20 @@ def test_environment_methods_accessible_in_controller(
         "temperature": False,
     }
 
+    def _call_env_methods(environment, altitude_asl, methods_called):
+        _ = environment.elevation
+        methods_called["elevation"] = True
+        _ = environment.wind_velocity_x(altitude_asl)
+        methods_called["wind_velocity_x"] = True
+        _ = environment.wind_velocity_y(altitude_asl)
+        methods_called["wind_velocity_y"] = True
+        _ = environment.speed_of_sound(altitude_asl)
+        methods_called["speed_of_sound"] = True
+        _ = environment.pressure(altitude_asl)
+        methods_called["pressure"] = True
+        _ = environment.temperature(altitude_asl)
+        methods_called["temperature"] = True
+
     def controller_test_environment_access(  # pylint: disable=unused-argument
         time,
         sampling_rate,
@@ -758,29 +772,10 @@ def controller_test_environment_access(  # pylint: disable=unused-argument
         if time < 3.9:
             return None
 
-        # Test accessing various environment methods
         try:
-            _ = environment.elevation
-            methods_called["elevation"] = True
-
-            _ = environment.wind_velocity_x(altitude_asl)
-            methods_called["wind_velocity_x"] = True
-
-            _ = environment.wind_velocity_y(altitude_asl)
-            methods_called["wind_velocity_y"] = True
-
-            _ = environment.speed_of_sound(altitude_asl)
-            methods_called["speed_of_sound"] = True
-
-            _ = environment.pressure(altitude_asl)
-            methods_called["pressure"] = True
-
-            _ = environment.temperature(altitude_asl)
-            methods_called["temperature"] = True
-
+            _call_env_methods(environment, altitude_asl, methods_called)
             air_brakes.deployment_level = 0.3
         except AttributeError as e:
-            # If any method is not accessible, the test should fail
             raise AssertionError(f"Environment method not accessible: {e}") from e
 
         return (time, air_brakes.deployment_level)

tests/unit/rocket/test_parachute.py

@@ -8,12 +8,12 @@
 
 
 def _make_parachute(**kwargs):
-    defaults = dict(
-        name="test",
-        cd_s=10.0,
-        trigger="apogee",
-        sampling_rate=100,
-    )
+    defaults = {
+        "name": "test",
+        "cd_s": 10.0,
+        "trigger": "apogee",
+        "sampling_rate": 100,
+    }
     defaults.update(kwargs)
     return Parachute(**defaults)
 
@@ -98,14 +98,14 @@ def test_from_dict_round_trip_preserves_drag_coefficient(self):
     def test_from_dict_defaults_drag_coefficient_to_1_4_when_absent(self):
         """Dicts serialized before drag_coefficient was added (no key) must
         fall back to 1.4 for backward compatibility."""
-        data = dict(
-            name="legacy",
-            cd_s=10.0,
-            trigger="apogee",
-            sampling_rate=100,
-            lag=0,
-            noise=(0, 0, 0),
+        data = {
+            "name": "legacy",
+            "cd_s": 10.0,
+            "trigger": "apogee",
+            "sampling_rate": 100,
+            "lag": 0,
+            "noise": (0, 0, 0),
             # no drag_coefficient key — simulates old serialized data
-        )
+        }
         parachute = Parachute.from_dict(data)
         assert parachute.drag_coefficient == pytest.approx(1.4)