Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Issue #68: team-09 - Write down some TO-DOs #111

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

KrWanderley
Copy link

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly
  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally
  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

No changes.

What is the new behavior?

The code does not change the behavior, it's just a few suggestions written on txt.

Does this introduce a breaking change?

  • Yes
  • No

Other information

:--)

@Gui-FernandesBR Gui-FernandesBR changed the title Issue #68 team09 Issue #68: team-09 - Aug 29, 2022
@Gui-FernandesBR Gui-FernandesBR linked an issue Aug 29, 2022 that may be closed by this pull request
@Gui-FernandesBR Gui-FernandesBR removed the request for review from giovaniceotto August 29, 2022 05:38
@Gui-FernandesBR Gui-FernandesBR changed the title Issue #68: team-09 - Issue #68: team-09 - Write down some TO-DOs Aug 29, 2022
@Gui-FernandesBR Gui-FernandesBR self-requested a review August 29, 2022 05:54
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Good Pull Request, I'm giving the points correponding to an easy task, as expected. Thank you for your collaboration!

@Gui-FernandesBR Gui-FernandesBR added 10 points Easy challenges! Easy and removed Easy labels Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
10 points Easy challenges! team-09
Projects
Development

Successfully merging this pull request may close these issues.

Write down some TO-DOs to the future hackathons
5 participants