Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Issue #66: team-01 - Simulated Midnight Sun using getting_started notebook file #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aasitvora99
Copy link

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly
  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally
  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

Enter text here...

What is the new behavior?

Enter text here...

Does this introduce a breaking change?

  • Yes
  • No

Other information

Enter text here...

@Gui-FernandesBR Gui-FernandesBR self-requested a review August 28, 2022 16:25
@Gui-FernandesBR Gui-FernandesBR linked an issue Aug 28, 2022 that may be closed by this pull request
@Gui-FernandesBR Gui-FernandesBR changed the title Simulated Midnight Sun using getting_started notebook file Issue #66: team-01 - Simulated Midnight Sun using getting_started notebook file Aug 28, 2022
@FranzYuri FranzYuri self-requested a review August 28, 2022 16:26
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's approved, @FranzYuri add your review as well!

@Gui-FernandesBR Gui-FernandesBR removed the request for review from giovaniceotto August 28, 2022 17:00
@Gui-FernandesBR
Copy link
Member

Good implementation, with more then requested by the challenge itself. Thank you @aasitvora99 for your first contribution, we are adding extra 20% for this pull requested :)

@Gui-FernandesBR Gui-FernandesBR added 10 points Easy challenges! extra_points Exceptionally ingenious solutions Easy and removed Easy labels Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
10 points Easy challenges! extra_points Exceptionally ingenious solutions team-01
Projects
Development

Successfully merging this pull request may close these issues.

Learn to use
4 participants