Skip to content

chore(lint): Replace eslint-plugin-import with eslint-plugin-import-x #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

chore(lint): Replace eslint-plugin-import with eslint-plugin-import-x #1766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eef0bb
Replace `eslint-plugin-import` with `eslint-plugin-import-x`
tassoevan Oct 14, 2025
ef5105a
Merge branch 'main' into chore/replace-import-plugin
tassoevan Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 25 additions & 26 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@

// @ts-check

import pluginImport from 'eslint-plugin-import';
import { importX } from 'eslint-plugin-import-x';
import pluginJsxA11y from 'eslint-plugin-jsx-a11y';
import * as mdx from 'eslint-plugin-mdx';
import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended';
import pluginReact from 'eslint-plugin-react';
import pluginReactHooks from 'eslint-plugin-react-hooks';
import storybook from 'eslint-plugin-storybook';
import globals from 'globals';
// eslint-disable-next-line import/no-unresolved
import tseslint from 'typescript-eslint';

export default tseslint.config(
Expand Down Expand Up @@ -344,23 +343,23 @@ export default tseslint.config(
},
},
plugins: {
import: pluginImport,
'import-x': importX,
},
settings: {
'import/resolver': {
'import-x/resolver': {
node: {
extensions: ['.mjs', '.js', '.json'],
},
},
'import/extensions': ['.js', '.mjs', '.jsx'],
'import/core-modules': [],
'import/ignore': [
'import-x/extensions': ['.js', '.mjs', '.jsx'],
'import-x/core-modules': [],
'import-x/ignore': [
'node_modules',
'\\.(coffee|scss|css|less|hbs|svg|json)$',
],
},
rules: {
'import/no-unresolved': [
'import-x/no-unresolved': [
'error',
{
commonjs: true,
Expand All @@ -369,15 +368,15 @@ export default tseslint.config(
ignore: ['^meteor/.+$'],
},
],
'import/named': 'off',
'import/default': 'off',
'import/namespace': 'off',
'import/export': 'error',
'import/no-named-as-default': 'off',
'import/no-named-as-default-member': 'off',
'import/first': 'error',
'import/no-duplicates': 'error',
'import/order': [
'import-x/named': 'off',
'import-x/default': 'off',
'import-x/namespace': 'off',
'import-x/export': 'error',
'import-x/no-named-as-default': 'off',
'import-x/no-named-as-default-member': 'off',
'import-x/first': 'error',
'import-x/no-duplicates': 'error',
'import-x/order': [
'error',
{
'newlines-between': 'always',
Expand All @@ -397,12 +396,12 @@ export default tseslint.config(
},
},
],
'import/newline-after-import': 'error',
'import/no-absolute-path': 'error',
'import/no-dynamic-require': 'error',
'import/no-self-import': 'error',
'import/no-cycle': 'off',
'import/no-useless-path-segments': 'error',
'import-x/newline-after-import': 'error',
'import-x/no-absolute-path': 'error',
'import-x/no-dynamic-require': 'error',
'import-x/no-self-import': 'error',
'import-x/no-cycle': 'off',
'import-x/no-useless-path-segments': 'error',
},
},
eslintPluginPrettierRecommended,
Expand Down Expand Up @@ -447,7 +446,7 @@ export default tseslint.config(
'no-useless-constructor': 'off',
},
settings: {
'import/resolver': {
'import-x/resolver': {
node: {
extensions: ['.js', '.jsx', '.ts', '.tsx'],
},
Expand Down Expand Up @@ -528,10 +527,10 @@ export default tseslint.config(
{
files: ['packages/fuselage/**/*.{js,mdx}'],
rules: {
'import/no-unresolved': 'off',
'import-x/no-unresolved': 'off',
},
settings: {
'import/resolver': {
'import-x/resolver': {
node: {
extensions: ['.js', '.jsx', '.ts', '.tsx'],
},
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@rocket.chat/prettier-config": "workspace:~",
"eslint": "~9.37.0",
"eslint-import-resolver-typescript": "~4.4.4",
"eslint-plugin-import": "~2.32.0",
"eslint-plugin-import-x": "~4.16.1",
"eslint-plugin-jsx-a11y": "~6.10.2",
"eslint-plugin-mdx": "~3.6.2",
"eslint-plugin-prettier": "~5.5.4",
Expand Down
Loading
Loading