Skip to content

Conversation

KrishnaShuk
Copy link
Contributor

@KrishnaShuk KrishnaShuk commented Jan 15, 2025

Tool-Tips positioned above Message Toolbox

Acceptance Criteria fulfillment

  • The tooltip should be fully visible and display the complete text without being truncated.

Fixes #900

Video/Screenshots

Screencast.from.2025-01-15.15-20-10.webm

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr- 901 after approval.

@dhairyashiil
Copy link
Contributor

Hello @KrishnaShuk, the tooltip arrow should point to the message toolbox, not the icon inside. If you want to change the position from bottom to top, please consider this point as well: Observe the current tooltip position, it's not directly on the icon.

@KrishnaShuk
Copy link
Contributor Author

Will lift up the tooltip arrow that will point to the message toolbox. @dhairyashiil thanks for suggestion.

@dhairyashiil
Copy link
Contributor

Will lift up the tooltip arrow that will point to the message toolbox. @dhairyashiil thanks for suggestion.

Well, I have an idea. Instead of changing the position of the tooltip from bottom to top, you can change the positioning of the message toolbox by shifting it upwards. However, there's a catch: the message toolbar positioning differs for normal messages and quoted messages, so you need to ensure that the toolbar is usable for both types of messages.

@Spiral-Memory
Copy link
Collaborator

If you shift it to top, then the problem will again be the same when a message is at the top i believe, can we make it dynamic ?

@KrishnaShuk
Copy link
Contributor Author

You are right @Spiral-Memory , will try to make it more dynamic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Tooltip Content Not Fully Visible in UI Element

3 participants