-
Notifications
You must be signed in to change notification settings - Fork 312
fix: React-Native project fails to load up during development #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Hi @SinghaAnirban005 Why it is showing these many changes ? |
Can you please ignore those yarn cache files |
Hi @SinghaAnirban005 |
Might be because of including a new library in the react-native package !! |
Sure, meanwhile I'm approving it |
@Spiral-Memory This can be tackled by using workspace:^ instead of hardcoding version number . Due to hardcoding version number it was searching for the api package in the npm registry But few considerations before using workspace:^ :
So the solution given in the PR can be thought of as a temporary workaround . I didn't want to delete the existing yarn.lock file so i had to come up with the given solution |
Then do one think, delete that, run yarn, to get a new lock file and then we can have that Will that work ? |
deleting the yarn.lock file inside the native repo and then running a yarn install wont generate a new lockfile since it is treated as a yarn workspace i believe there should be only a central lockfile for this monorepo at the root level |
I’ve tested this as well. Using workspace:^ in embeddedchat/api leads to dependency issues, unless the expo package is installed at the root level. Additionally, to make it compatible, some more React Native specific packages also need to be added to the monorepo’s dependencies. |
Absolutely ! |
@SinghaAnirban005 @abirc8010 @devanshkansagra |
React-Native project development fails
Acceptance Criteria fulfillment
Reason I have hardcoded instead of using workspace:^
Fixes #1000
Video/Screenshots
2025-04-04.23-49-34.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1001 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.