Workaround ros2/rosidl_typesupport#120 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanTheEngineer
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sloretz)
sloretz
deleted the
sloretz__interfaces-with-group-name-multi-typesupport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around ros2/rosidl_typesupport#120.
When the ROS workspace has multiple typesupports, and the RMW implementation uses the introspection typesupport, and
rosidl_interfaces_group()is given given a value forgroup, the introspection typesupport fails to load language specific shared libraries at runtime.This works around the bug by making the generated target names use the group name as their prefix, and then making
alias()targets withnameused as the prefix. This makes sure the generated shared libraries have the name that the introspection type support expects.If the upstream issue is fixed, this workaround will continue to work.
@IanTheEngineer FYI
This change is