-
Notifications
You must be signed in to change notification settings - Fork 0
Neu folder handler #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
crispy-caesus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brauchen wir das ganze lua zeugs noch oder ist das ne config die nicht geht?
configs/nvim/.ignore
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was macht das?
configs/nvim/.stylua.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
configs/nvim/LICENSE
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move a lot of the installuserconfig stuff into seperate functions, this is hard to read
optimally you would have the install function pretty much only have descriptive calls to functions so you can see
- getting user input
- checking config selection
- etc
which would make the code a lot easier to navigate for new people/if you haven't worked on it in a long time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also split up functions to create, move, perms seperately
a python script to make and handle the members
(/media/share/roboag/User/...)
also added a fix to the userconfiginstaller, now the config gets chowned by the user the config is installed for