Blox deviations - #46
Draft
hcollinsblox wants to merge 3 commits into
Draft
Conversation
Work run during a drain can call `schedule`, which appends to the table the drain is walking. Generalised iteration is not guaranteed to reach entries added after it started, so an effect scheduled by another effect could be skipped for the rest of the batch and then discarded by the `table.clear` that ends it. Both drains now index by position, which re-reads the length each time round. Co-authored-by: Cursor <cursoragent@cursor.com>
Blox has been running a copy of this file with seven additions on top. They are
brought back here so there is one implementation rather than two, each marked
BLOX with the reason it exists so they can be reviewed separately:
1. `peek`, which reads without subscribing and passes a plain value through
2. `isGetter` / `isCallable`
3. an optional `scheduleWork` per effect, which also defers the first run
4. a cleanup function returned from an effect body
5. `debugName` on signals, computeds and effects, plus an internals flag
6. `createInternalSource`, which notifies without flushing
7. reporting for a read that named no scope, which subscribes nothing and so
reads correctly once and then never updates
Diagnostics arrive through `setHooks` and `configure` rather than a dependency,
so nothing here knows about the runtime using it. Blox's copy read them from its
own Debug and Profiler modules, which is what kept the file from living here.
Co-authored-by: Cursor <cursoragent@cursor.com>
hcollinsblox
had a problem deploying
to
integration
August 13, 2026 20:56 — with 
GitHub Actions
Error
GitHub Actions
Error
Collaborator
|
Can you instead submit this in the form of 1 or more feature requests (github issues or individual PRs)? This seems to be a collection of ad-hoc changes that are all somewhat related, but not quite. |
hcollinsblox
requested a deployment
to
integration
September 10, 2026 14:53 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.