feat(react): backport insertion and Effect Event hooks - #28
Draft
christopher-buss wants to merge 1 commit into
Draft
feat(react): backport insertion and Effect Event hooks#28christopher-buss wants to merge 1 commit into
christopher-buss wants to merge 1 commit into
Conversation
christopher-buss
marked this pull request as draft
August 31, 2026 16:08
christopher-buss
force-pushed
the
backport-react-19-2-use-effect-event
branch
from
August 31, 2026 22:47
a255ffc to
0388ee5
Compare
Mirror React 18 useInsertionEffect and React 19.2 useEffectEvent, including commit ordering, Debug Tools support, DEV validation, and upstream-derived coverage. Co-authored-by: Codex <noreply@openai.com>
christopher-buss
force-pushed
the
backport-react-19-2-use-effect-event
branch
from
September 1, 2026 01:41
0388ee5 to
646a31b
Compare
christopher-buss
force-pushed
the
backport-react-19-2-use-effect-event
branch
2 times, most recently
from
September 6, 2026 17:20
472d35e to
8e0a62c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport React 18's
useInsertionEffectmutation-phase semantics and React 19.2'suseEffectEventcommit-safe callback semantics. Add public and dispatcher APIs, reconciler commit behavior, Debug Tools inspection, and upstream-ordered Jest-Lua coverage. Include pinned source and test ledgers with explicit React-Luau capability boundaries and deviations.Verification
0.18.1: full tree passes0.28.0: all changed Luau files pass with zero errors or warnings0.731: all changed Luau files compile8e0a62c22cebcd6b66cdd8d34e7ee93daa96ad33/ tree5360be0f:useEffectEvent: 14 passed, 0 faileduseInsertionEffect: 7 passed, 0 failedA127D0C8FF96273612E30FF21543AD6F57EE92ADACB4B4C76BCFD19D73A7F57D0C8BF52F4B5901B129E4882E2903CAC0412D6E403F8328269EE624D973DAB50B42E12A0CAE56B80C92334E9CC19A85DA514B8AB6C8D7F38C83A43BAC64BEA81DA821318C28E7053619A4D937802C8A1DF91B7176678AAED13F036237088494AEgit diff --check: passesbash bin/testing.sh: standalone runner remains unavailable becauseroblox-cliis not installedGenerated with Codex.