Skip to content

fix: fix title parsing (#11) and publication year (#4) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giancarlodigi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fix title parsing (#11) and publication year (#4) #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/chrome/content/journal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,27 @@ Journal = {
})
.then(dataJson => {
var Title = Utilities.safeGetFromJson(dataJson, ["title"]);

// If there's a subtitle, append it to the title separated by ": "
var Subtitles = Utilities.safeGetFromJson(dataJson, ["subtitle"]);
if (Subtitles && Subtitles.length > 0) {
var subtitleText = Subtitles[0];
Title = Title ? Title + ": " + subtitleText : subtitleText;
}

var Authors = this.generateAuthors(Utilities.safeGetFromJson(dataJson, ["author"]));
var Publication = Utilities.safeGetFromJson(dataJson, ["container-title"]);
var Volume = Utilities.safeGetFromJson(dataJson, ["volume"]);
var Issue = Utilities.safeGetFromJson(dataJson, ["issue"]);
var Pages = Utilities.safeGetFromJson(dataJson, ["page"]);
var PublishDate = this.generateDate(Utilities.safeGetFromJson(dataJson, ["published", "date-parts"]));

// Check if there is a published-print date and use it if available
var publishedPrintDate = Utilities.safeGetFromJson(dataJson, ["published-print", "date-parts"]);
if (publishedPrintDate && publishedPrintDate.length > 0) {
PublishDate = this.generateDate(publishedPrintDate);
}

var JournalAbbr = Utilities.safeGetFromJson(dataJson, ["container-title-short"]);
var Language = Utilities.safeGetFromJson(dataJson, ["language"]);
return {
Expand Down