Main Menu: UI Improvements #245
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short and concise description about my pull request:
TODOs:
Longer / More informative description about what my pull request does:
Make dialog "Choose a login method" closable:
Implement closable
RT_Dialog_YesNovia X button by adding argumentclosableXthat adds the X button to the top right that adds closes the RT_Dialog_YesNo withWindow.doCloseX.Set "25555" as default value for port input in
ConnectionManager:Implement default values for
RT_Dialog_Inputsby adding argumentdefaultValuesthat, if set, initializesResultswith default values.Load the server list async and add (simple) loading animation:
Added the method
GetServersAsync()that setsIsLoading, while loading. When server list is fetched,IsLoading = falseand the server list is displayed.🚧 I also added a close X button while fetching servers, that does currently nothing. I fear problems closing the dialog without properly stopping the server search in the background.
Reword "login" with connect:
Changing only strings. Though, when I read "Login" I would expect username/password, so I think "Connect" fits better.