Skip to content

Update equivalent ribbed groove #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RichardPfr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update equivalent ribbed groove #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pyroll/core/grooves/equivalent_ripped_groove.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ def __init__(
nominal_outer_diameter: float,
usable_width: float,
depth: float,
rib_flank_angle: Optional[float] = None,

pad_angle: float = 0,
**kwargs
Expand All @@ -42,6 +43,13 @@ def __init__(
:param kwargs: more keyword arguments passed to the GenericElongationGroove constructor
"""

self.nominal_outer_diameter = nominal_outer_diameter
self.base_body_height = base_body_height
self.rib_distance = rib_distance
self.rib_width = rib_width
self.rib_flank_angle = rib_flank_angle


pad_angle = np.deg2rad(pad_angle)
rib_angle = np.deg2rad(rib_angle)

Expand Down