-
Notifications
You must be signed in to change notification settings - Fork 13
[v6] CI fixes #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[v6] CI fixes #753
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c31e0bd
Bring back CI machine with Xcode 13.4.0 for `make-release` job
ajpallares 04e4823
run `bundle install` in `insert-changelog-latest-in-main-if-needed`
ajpallares 6596e22
Use Ruby 3.2 in `insert-changelog-latest-in-main-if-needed` CI job
ajpallares 7f873a0
Merge branch 'base/6.3.0' into v6/ci-fixes
ajpallares File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm it's weird we need to downgrade to such an old version to run that job... What's the issue on the newer Xcode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point. I bumped the version of Xcode in #750 thinking it would be harmless, but it turned out that this produced a CI failure (e.g. https://app.circleci.com/pipelines/github/RevenueCat/cordova-plugin-purchases/3149/workflows/38f5526f-6475-42da-a54d-b50dd2510b9f/jobs/10122) when trying to release. So I rolled it back to the same version as before and it worked.
Ideally we should fix this issue but I didn't want to block the release for this.