Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ jobs:
make-release:
description: "Publishes the new version and creates a github release"
macos:
xcode: 16.4.0
xcode: 13.4.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm it's weird we need to downgrade to such an old version to run that job... What's the issue on the newer Xcode?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point. I bumped the version of Xcode in #750 thinking it would be harmless, but it turned out that this produced a CI failure (e.g. https://app.circleci.com/pipelines/github/RevenueCat/cordova-plugin-purchases/3149/workflows/38f5526f-6475-42da-a54d-b50dd2510b9f/jobs/10122) when trying to release. So I rolled it back to the same version as before and it worked.
Ideally we should fix this issue but I didn't want to block the release for this.

steps:
- checkout
- npm-dependencies
Expand Down Expand Up @@ -285,9 +285,11 @@ jobs:
insert-changelog-latest-in-main-if-needed:
description: "If the release corresponds to a previous version, creates a PR to insert the release changelog into main's CHANGELOG.md"
docker:
- image: cimg/ruby:2.6
- image: cimg/ruby:3.2
steps:
- checkout
- revenuecat/install-gem-mac-dependencies:
cache-version: v1
- revenuecat/trust-github-key
- revenuecat/setup-git-credentials
- run:
Expand Down