Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new getGameHashes() function #114

Merged
merged 3 commits into from
Jan 8, 2025
Merged

feat: add new getGameHashes() function #114

merged 3 commits into from
Jan 8, 2025

Conversation

joshraphael
Copy link
Contributor

@joshraphael joshraphael commented Jan 8, 2025 •
edited
Loading

Changes:

  • adds new getGameHashes() to README
  • adds new getGameHashes() function
  • Unit tests new getGameHashes() function
  • Updates getConsoleIds() test coverage (for failing pnpm test:coverage)
  • Updates getRecentGameAwards() test coverage (for failing pnpm test:coverage)

Closes #106

wescopeland
wescopeland reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Just 2 nits here and we'll probably be good to go. The NPM registry has been having issues with GitHub Actions all day today, so that's probably the explanation behind the CI failure.

src/game/getGameHashes.ts Outdated Show resolved Hide resolved
src/game/getGameHashes.ts Outdated Show resolved Hide resolved
joshraphael and others added 2 commits January 8, 2025 15:05
@wescopeland wescopeland merged commit 18c12fb into RetroAchievements:main Jan 8, 2025
1 check passed
@joshraphael joshraphael deleted the issue-106 branch January 8, 2025 22:10
@joshraphael joshraphael mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wescopeland wescopeland wescopeland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add getGameHashes()
2 participants
@joshraphael @wescopeland