Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BaseSelectNative component #3169

Conversation

wescopeland
Copy link
Member

This PR adds a new vendor component: BaseSelectNative. For the time being, this component is only used in FullPaginator.

Mature component libraries tend to have multiple flavors of select components to choose from. For example, a subsequent PR will add a BaseSelectAsync component which allows you to search for the option (ie: a user to send a message to).

BaseSelect has highly-customizable UX, but has slow rendering performance on lists that have potentially hundreds of options. BaseSelectNative renders options very quickly, with the trade-off of having virtually no customizable UX for the select options.

Before
Screenshot 2025-02-02 at 6 25 55 PM

After
Screenshot 2025-02-02 at 6 26 16 PM

@wescopeland wescopeland requested a review from a team February 2, 2025 23:29
@wescopeland wescopeland merged commit 30eb0cb into RetroAchievements:master Feb 5, 2025
9 checks passed
@wescopeland wescopeland deleted the base-select-native-pagination branch February 5, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants